hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohammad Islam" <misla...@yahoo.com>
Subject Re: Review Request 17930: HIVE-6402: Improve Hive behavior when deleting data with miss configured Trash
Date Tue, 11 Feb 2014 02:35:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17930/#review34163
-----------------------------------------------------------


Looks good with simple comments.


metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17930/#comment64183>

    adding " & dataSuccess" is required here?
    



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17930/#comment64182>

    Is it possible none of the data deletion succeeds? If that is possible,  the message doesn't
seem correct.
    


- Mohammad Islam


On Feb. 11, 2014, 1:33 a.m., Szehon Ho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17930/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 1:33 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6402
>     https://issues.apache.org/jira/browse/HIVE-6402
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> It is probably not desirable to forcibly delete the data if the trash is misconfigured.
 So this change at least informs the user by throwing an exception, indicating that the data
deletion failed.
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 4905be0 
> 
> Diff: https://reviews.apache.org/r/17930/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Szehon Ho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message