hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lefty Leverenz" <leftylever...@gmail.com>
Subject Re: Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez
Date Sat, 08 Feb 2014 05:48:36 GMT


> On Feb. 8, 2014, 5:26 a.m., Lefty Leverenz wrote:
> >

I don't know how to unopen an issue, and I'm not sure what an open issue is -- but clearly
I wasn't supposed to open issues for these nits.  Sorry, new to review board.  Maybe I should
RTFM.


> On Feb. 8, 2014, 5:26 a.m., Lefty Leverenz wrote:
> > conf/hive-default.xml.template, line 2311
> > <https://reviews.apache.org/r/17471/diff/3/?file=480686#file480686line2311>
> >
> >     init cap Yarn

Not an issue, please drop.


> On Feb. 8, 2014, 5:26 a.m., Lefty Leverenz wrote:
> > conf/hive-default.xml.template, line 2312
> > <https://reviews.apache.org/r/17471/diff/3/?file=480686#file480686line2312>
> >
> >     HiveServer2 & Tez (nits but let's do it right)

Not an issue, please drop.


> On Feb. 8, 2014, 5:26 a.m., Lefty Leverenz wrote:
> > conf/hive-default.xml.template, line 2313
> > <https://reviews.apache.org/r/17471/diff/3/?file=480686#file480686line2313>
> >
> >     init cap Tez

Not an issue, please drop.


> On Feb. 8, 2014, 5:26 a.m., Lefty Leverenz wrote:
> > conf/hive-default.xml.template, line 2321
> > <https://reviews.apache.org/r/17471/diff/3/?file=480686#file480686line2321>
> >
> >     init cap Tez

Not an issue, please drop.


> On Feb. 8, 2014, 5:26 a.m., Lefty Leverenz wrote:
> > conf/hive-default.xml.template, line 2326
> > <https://reviews.apache.org/r/17471/diff/3/?file=480686#file480686line2326>
> >
> >     Also need to document hive.server2.tez.initialize.default.sessions here.  (Not
a nit.)

Okay, this could be considered an issue (maybe).


- Lefty


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17471/#review34010
-----------------------------------------------------------


On Feb. 8, 2014, 2:49 a.m., Vikram Dixit Kumaraswamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17471/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2014, 2:49 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6325
>     https://issues.apache.org/jira/browse/HIVE-6325
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Enable using multiple concurrent sessions in tez.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3f50361 
>   conf/hive-default.xml.template 420d959 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9b2e219 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java b8552a3 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 22a21c9 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 64a8a60 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java PRE-CREATION

>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionState.java PRE-CREATION

>   service/src/java/org/apache/hive/service/server/HiveServer2.java 8700c5b 
> 
> Diff: https://reviews.apache.org/r/17471/diff/
> 
> 
> Testing
> -------
> 
> Added multi-threaded junit tests.
> 
> 
> Thanks,
> 
> Vikram Dixit Kumaraswamy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message