hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gunther Hagleitner" <ghagleit...@hortonworks.com>
Subject Re: Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez
Date Fri, 07 Feb 2014 21:14:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17471/#review33958
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java
<https://reviews.apache.org/r/17471/#comment63793>

    session type isn't used anywhere. shoudl be removed.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java
<https://reviews.apache.org/r/17471/#comment63795>

    getInstance takes a hive conf obj. i thought initially you were keeping different pools
for each instance of it.
    
    however, it looks like you only need it to init. i think it would be better if you did
the init in a separate method. (for instance there's a call to getInstance(null, null) in
stop which might create an unintialized instance.)



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java
<https://reviews.apache.org/r/17471/#comment63794>

    nit. trailing ws.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java
<https://reviews.apache.org/r/17471/#comment63791>

    I don't know why you dropped the issue. But the comment still doesn't match the signature
fo the method.



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java
<https://reviews.apache.org/r/17471/#comment63792>

    I think I'd be good to document what the idea behind "canworkwithsamesession" is.


- Gunther Hagleitner


On Feb. 6, 2014, 2:08 a.m., Vikram Dixit Kumaraswamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17471/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 2:08 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6325
>     https://issues.apache.org/jira/browse/HIVE-6325
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Enable using multiple concurrent sessions in tez.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 89c9349 
>   conf/hive-default.xml.template 420d959 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9b2e219 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java b8552a3 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 22a21c9 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 64a8a60 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java PRE-CREATION

>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionState.java PRE-CREATION

>   service/src/java/org/apache/hive/service/server/HiveServer2.java 8700c5b 
> 
> Diff: https://reviews.apache.org/r/17471/diff/
> 
> 
> Testing
> -------
> 
> Added multi-threaded junit tests.
> 
> 
> Thanks,
> 
> Vikram Dixit Kumaraswamy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message