hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Re: Review Request 17634: ZeroCopy and Direct ByteBuffer decompression for ORC files
Date Thu, 06 Feb 2014 18:47:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17634/#review33815
-----------------------------------------------------------



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/17634/#comment63427>

    some orc configs starts with "hive.exec.orc" and others with "hive.orc". seems to be inconsistent.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java
<https://reviews.apache.org/r/17634/#comment63428>

    nit: please replace tabs with spaces


- Prasanth_J


On Feb. 6, 2014, 3:19 a.m., Gopal V wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17634/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 3:19 a.m.)
> 
> 
> Review request for hive, Gunther Hagleitner, Owen O'Malley, and Prasanth_J.
> 
> 
> Bugs: HIVE-6347
>     https://issues.apache.org/jira/browse/HIVE-6347
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Zero Copy Read path for ORC + Zlib&Snappy decompressors wrapping the DirectDecompressor
interface from HADOOP-10047
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 84ee78f 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/DirectDecompressionCodec.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java 6da3d03 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java a5747a6 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/Reader.java 2bab0ce 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java 56f25b7 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 0df82b9 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/SnappyCodec.java e3131a3 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java d904c44

>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/ZlibCodec.java a75fdea 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFile.java 03fc705 
> 
> Diff: https://reviews.apache.org/r/17634/diff/
> 
> 
> Testing
> -------
> 
> Updated seek tests to test with zero-copy reads on.
> 
> TPC-DS queries on scale=2 flat ORC data.
> 
> 
> Thanks,
> 
> Gopal V
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message