hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request 17779: HIVE-6373: TestCliDriverMethods test can cause entire build to fail
Date Thu, 06 Feb 2014 04:49:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17779/#review33757
-----------------------------------------------------------



cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java
<https://reviews.apache.org/r/17779/#comment63390>

    I think it is better worded as something like - "It is better to do this as the first
and last part of each test".
    


- Thejas Nair


On Feb. 6, 2014, 3:16 a.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17779/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 3:16 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6373
>     https://issues.apache.org/jira/browse/HIVE-6373
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Make sure custom SecurityManager is unregistered when the test is finished.
> 
> 
> Diffs
> -----
> 
>   cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java a0e9505 
> 
> Diff: https://reviews.apache.org/r/17779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message