hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jitendra Pandey" <jiten...@hortonworks.com>
Subject Re: Review Request 17622: VectorExpressionWriter for date and decimal datatypes.
Date Thu, 06 Feb 2014 00:34:48 GMT


> On Feb. 3, 2014, 6:20 p.m., Eric Hanson wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java, line 208
> > <https://reviews.apache.org/r/17622/diff/1/?file=462257#file462257line208>
> >
> >     Please add a comment why you are using decimal.* and why it's different than
the others.

Added a patch in HIVE-6333 that addresses this comment. This patch is incorporated in HIVE-6333.


- Jitendra


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17622/#review33378
-----------------------------------------------------------


On Jan. 31, 2014, 10:19 p.m., Jitendra Pandey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17622/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 10:19 p.m.)
> 
> 
> Review request for hive and Eric Hanson.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> VectorExpressionWriter for date and decimal datatypes.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 729908a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java f513188

>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpressionWriter.java
e5c3aa4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpressionWriterFactory.java
a242fef 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java ad96fa5 
>   ql/src/test/queries/clientpositive/vectorization_decimal_date.q PRE-CREATION 
>   ql/src/test/results/clientpositive/vectorization_decimal_date.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17622/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jitendra Pandey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message