hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohammad Islam" <misla...@yahoo.com>
Subject Re: Review Request 17661: HIVE-6327: A few mathematic functions don't take decimal input
Date Mon, 03 Feb 2014 19:50:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17661/#review33478
-----------------------------------------------------------


Looks clean.
Minor comments to consider.


ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLn.java
<https://reviews.apache.org/r/17661/#comment62920>

    Is it required?



ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog.java
<https://reviews.apache.org/r/17661/#comment62921>

    is it required?



ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog.java
<https://reviews.apache.org/r/17661/#comment62923>

    Please remove this.



ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog.java
<https://reviews.apache.org/r/17661/#comment62925>

    does the base < 1.0 should be changed to base <= 1.0  as done in the old code?



ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSin.java
<https://reviews.apache.org/r/17661/#comment62922>

    same here


- Mohammad Islam


On Feb. 3, 2014, 2:26 p.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17661/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 2:26 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6327
>     https://issues.apache.org/jira/browse/HIVE-6327
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added methods for those UDFs such that decimal type can be accepted and evaluated.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAcos.java 4e2b50e 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAsin.java f7adce4 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAtan.java fb861a5 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCos.java d9ce12d 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFExp.java 9c8c836 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLn.java 883b541 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog.java a90e622 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog10.java 1cc70a4 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog2.java e3f2026 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMath.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRadians.java 47e18ee 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSin.java e714c17 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSqrt.java 4eefc8c 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFTan.java 8ebd727 
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFMath.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17661/diff/
> 
> 
> Testing
> -------
> 
> New unit test cases are added to test all the UDFs regarding decimal input.
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message