Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C536610A35 for ; Fri, 31 Jan 2014 15:40:55 +0000 (UTC) Received: (qmail 19595 invoked by uid 500); 31 Jan 2014 15:40:49 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 19312 invoked by uid 500); 31 Jan 2014 15:40:49 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 19152 invoked by uid 99); 31 Jan 2014 15:40:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Jan 2014 15:40:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ACE6E1D4718; Fri, 31 Jan 2014 15:40:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9080707762110655308==" MIME-Version: 1.0 Subject: Re: Review Request 17483: Support for hbase filters for composite keys From: "Swarnim Kulkarni" To: "Swarnim Kulkarni" , "hive" Date: Fri, 31 Jan 2014 15:40:46 -0000 Message-ID: <20140131154046.22330.40224@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Swarnim Kulkarni" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/17483/ X-Sender: "Swarnim Kulkarni" References: <20140129060456.6810.45079@reviews.apache.org> In-Reply-To: <20140129060456.6810.45079@reviews.apache.org> Reply-To: "Swarnim Kulkarni" X-ReviewRequest-Repository: hive-git --===============9080707762110655308== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17483/#review33325 ----------------------------------------------------------- hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java Could you please elaborate on this a little more? I had resorted to using reflections because this composite class implementation is provided by the consumer at runtime as a jar. - Swarnim Kulkarni On Jan. 29, 2014, 6:04 a.m., Swarnim Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17483/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2014, 6:04 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6290 > https://issues.apache.org/jira/browse/HIVE-6290 > > > Repository: hive-git > > > Description > ------- > > Support to be able to provide scan filter for hive/hbase integration for composite keys. > > > Diffs > ----- > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseCompositeKey.java 5008f15 > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 899ccce > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java 704fcb9 > hbase-handler/src/test/org/apache/hadoop/hive/hbase/HBaseTestCompositeKey.java 13c344b > ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java d39ee2e > ql/src/java/org/apache/hadoop/hive/ql/index/IndexSearchCondition.java 5f1329c > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java e50026b > > Diff: https://reviews.apache.org/r/17483/diff/ > > > Testing > ------- > > Tested using locally created data and debug logs that the filter gets applied on the scan. > > > Thanks, > > Swarnim Kulkarni > > --===============9080707762110655308==--