Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 44C6B10C78 for ; Tue, 28 Jan 2014 22:30:40 +0000 (UTC) Received: (qmail 21805 invoked by uid 500); 28 Jan 2014 22:30:38 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 21684 invoked by uid 500); 28 Jan 2014 22:30:38 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 21674 invoked by uid 99); 28 Jan 2014 22:30:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jan 2014 22:30:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 67B8A1D4693; Tue, 28 Jan 2014 22:30:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7761195632879970232==" MIME-Version: 1.0 Subject: Re: Review Request 17470: HIVE-6112 : SQL std auth - support new privileges INSERT, DELETE From: "Thejas Nair" To: "Thejas Nair" , "hive" Date: Tue, 28 Jan 2014 22:30:34 -0000 Message-ID: <20140128223034.20513.29706@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/17470/ X-Sender: "Thejas Nair" References: <20140128222754.6810.25925@reviews.apache.org> In-Reply-To: <20140128222754.6810.25925@reviews.apache.org> Reply-To: "Thejas Nair" X-ReviewRequest-Repository: hive-git --===============7761195632879970232== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17470/ ----------------------------------------------------------- (Updated Jan. 28, 2014, 10:30 p.m.) Review request for hive. Changes ------- HIVE-6112.2.patch - minor cleanup Bugs: HIVE-6112 https://issues.apache.org/jira/browse/HIVE-6112 Repository: hive-git Description ------- Add INSERT, DELETE privileges for SQL Standard auth. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 216c361 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/Privilege.java dbbe210 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeRegistry.java 960f291 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeType.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java 7425150 ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/AuthorizationTestUtil.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/ListSizeMatcher.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/PrivilegesTestBase.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestHiveAuthorizationTaskFactory.java 77148b8 ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestPrivilegesV1.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestPrivilegesV2.java PRE-CREATION ql/src/test/queries/clientnegative/authorization_invalid_priv_v1.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_invalid_priv_v2.q PRE-CREATION ql/src/test/results/clientnegative/authorization_invalid_priv_v1.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_invalid_priv_v2.q.out PRE-CREATION Diff: https://reviews.apache.org/r/17470/diff/ Testing ------- unit tests and .q tests Thanks, Thejas Nair --===============7761195632879970232==--