Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 53D3A101C3 for ; Sat, 18 Jan 2014 02:08:27 +0000 (UTC) Received: (qmail 91338 invoked by uid 500); 18 Jan 2014 02:08:25 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 91291 invoked by uid 500); 18 Jan 2014 02:08:25 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 91276 invoked by uid 99); 18 Jan 2014 02:08:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Jan 2014 02:08:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C9C441D449D; Sat, 18 Jan 2014 02:08:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2404706112649052350==" MIME-Version: 1.0 Subject: Review Request 17084: Windows: percentComplete returned by job status from WebHCat is null From: "shanyu zhao" To: "Eugene Koifman" , "Eric Hanson" , "Thejas Nair" Cc: "hive" , "shanyu zhao" Date: Sat, 18 Jan 2014 02:08:24 -0000 Message-ID: <20140118020824.32122.96381@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "shanyu zhao" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/17084/ X-Sender: "shanyu zhao" Reply-To: "shanyu zhao" X-ReviewRequest-Repository: hive-git --===============2404706112649052350== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17084/ ----------------------------------------------------------- Review request for hive, Eugene Koifman, Eric Hanson, and Thejas Nair. Bugs: HIVE-6035 https://issues.apache.org/jira/browse/HIVE-6035 Repository: hive-git Description ------- HIVE-5511 fixed the same problem on Linux, but it still broke on Windows. The root cause of this problem is that the -Dlog4j.configuration needs to be in the format of "file://d:/xxx", so: "file://" + log4jProps.getAbsolutePath() works on Linux but does not work on Windows because it will produce "file://d:\xxx". This patch fixed two problem: 1) templeton.cmd correctly set WEBHCAT_CONF_DIR so that override_container_log4j.properties can be copied to distributed cache. I also modified it so that one can run timepleton.cmd (without any parameter) in standalone mode. 2) use hadoop class Path to convert the override log4j properties file path, the Path class will convert the platform specific path into uri style. Diffs ----- hcatalog/bin/templeton.cmd dcb976e hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java 73892cc Diff: https://reviews.apache.org/r/17084/diff/ Testing ------- Thanks, shanyu zhao --===============2404706112649052350==--