Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD8DB10CA4 for ; Mon, 13 Jan 2014 01:40:28 +0000 (UTC) Received: (qmail 62732 invoked by uid 500); 13 Jan 2014 01:40:21 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 62675 invoked by uid 500); 13 Jan 2014 01:40:18 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 62665 invoked by uid 99); 13 Jan 2014 01:40:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jan 2014 01:40:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E10451C06BC; Mon, 13 Jan 2014 01:40:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7692992721618151408==" MIME-Version: 1.0 Subject: Re: Review Request 16643: SQL std auth - support 'show all roles' From: "Navis Ryu" To: "Navis Ryu" , "hive" , "Thejas Nair" Date: Mon, 13 Jan 2014 01:40:12 -0000 Message-ID: <20140113014012.20235.44117@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Navis Ryu" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/16643/ X-Sender: "Navis Ryu" References: <20140106011146.26757.83147@reviews.apache.org> In-Reply-To: <20140106011146.26757.83147@reviews.apache.org> Reply-To: "Navis Ryu" X-ReviewRequest-Repository: hive-git --===============7692992721618151408== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16643/ ----------------------------------------------------------- (Updated Jan. 13, 2014, 1:40 a.m.) Review request for hive. Changes ------- Addressed comments. Bugs: HIVE-5941 https://issues.apache.org/jira/browse/HIVE-5941 Repository: hive-git Description ------- SHOW ALL ROLES - This will list all currently existing roles. This will be available only to the superuser. This task includes parser changes. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9e4f1c7 ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 713bd54 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g da745d7 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 5dff3fe ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 9b6fc3b ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 542d59a ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java bfd6b77 ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java 99dadb0 ql/src/test/queries/clientpositive/show_roles.q PRE-CREATION ql/src/test/results/clientpositive/show_roles.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16643/diff/ Testing ------- Thanks, Navis Ryu --===============7692992721618151408==--