Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0B1EA10558 for ; Mon, 6 Jan 2014 16:33:35 +0000 (UTC) Received: (qmail 74983 invoked by uid 500); 6 Jan 2014 16:32:51 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 74763 invoked by uid 500); 6 Jan 2014 16:32:36 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 74674 invoked by uid 99); 6 Jan 2014 16:32:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jan 2014 16:32:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A317C1D4170; Mon, 6 Jan 2014 16:32:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2664931321674256257==" MIME-Version: 1.0 Subject: Re: Review Request 16007: HIVE-5946 - DDL authorization task factory should be pluggable and tested From: "Brock Noland" To: "Thejas Nair" , "hive" , "Brock Noland" Date: Mon, 06 Jan 2014 16:32:27 -0000 Message-ID: <20140106163227.26785.12042@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brock Noland" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/16007/ X-Sender: "Brock Noland" References: <20140102215256.26158.82454@reviews.apache.org> In-Reply-To: <20140102215256.26158.82454@reviews.apache.org> Reply-To: "Brock Noland" X-ReviewRequest-Repository: hive-git --===============2664931321674256257== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Jan. 2, 2014, 9:52 p.m., Thejas Nair wrote: > > ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestDefaultHiveAuthorizationTaskFactory.java, line 430 > > > > > > A nit - > > I found it a little unintuitive to return the list from assertSize() call. Should we just have return type as void and do the check on another line. > > I don't have a strong opinion about this, so keeping it this way is also fine. > > > > I created a tiny class to match this fluent without adding a bunch of extra LOC. - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16007/#review31067 ----------------------------------------------------------- On Jan. 6, 2014, 4:31 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16007/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2014, 4:31 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5946 > https://issues.apache.org/jira/browse/HIVE-5946 > > > Repository: hive-git > > > Description > ------- > > Moves the task creation logic to a factory which is now tested with 20 unit tests. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1f242ea > ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java d0807d2 > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 448dae2 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 8bd0927 > ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactory.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestHiveAuthorizationTaskFactory.java PRE-CREATION > > Diff: https://reviews.apache.org/r/16007/diff/ > > > Testing > ------- > > 20 additional unit tests which pass > > > Thanks, > > Brock Noland > > --===============2664931321674256257==--