hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Hanson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-6186) error in vectorized Column-Column comparison filter for repeating case
Date Sat, 11 Jan 2014 02:07:51 GMT

    [ https://issues.apache.org/jira/browse/HIVE-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868607#comment-13868607
] 

Eric Hanson commented on HIVE-6186:
-----------------------------------

Code review at https://reviews.apache.org/r/16802/

> error in vectorized Column-Column comparison filter for repeating case
> ----------------------------------------------------------------------
>
>                 Key: HIVE-6186
>                 URL: https://issues.apache.org/jira/browse/HIVE-6186
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Query Processor
>    Affects Versions: 0.13.0
>            Reporter: Eric Hanson
>            Assignee: Eric Hanson
>         Attachments: HIVE-6186.01.patch
>
>
> FilterColumnCompareColumn.txt  contains this code:
>     } else if (inputColVector1.isRepeating && inputColVector2.isRepeating) {
>       if (nullPos1[0] || nullPos2[0]) {
>         batch.size = 0; 
>       } 
> This code examines nullPos1[0] and nullPos2[0] without checking that noNulls==false for
the appropriate vector. This could lead to incorrect results.
> We should review the case analysis for this template more generally to make sure that
all combinations are covered:
> left.noNulls        right.noNulls
> T                         T
> F                         T
> T                         F
> F                         F                 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message