hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-6185) DDLTask is inconsistent in creating a table and adding a partition when dealing with location
Date Mon, 13 Jan 2014 23:33:52 GMT

    [ https://issues.apache.org/jira/browse/HIVE-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870120#comment-13870120
] 

Hive QA commented on HIVE-6185:
-------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12622690/HIVE-6185.3.patch

{color:green}SUCCESS:{color} +1 4924 tests passed

Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/889/testReport
Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/889/console

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12622690

> DDLTask is inconsistent in creating a table and adding a partition when dealing with
location
> ---------------------------------------------------------------------------------------------
>
>                 Key: HIVE-6185
>                 URL: https://issues.apache.org/jira/browse/HIVE-6185
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.12.0
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>         Attachments: HIVE-6185.1.patch, HIVE-6185.2.patch, HIVE-6185.3.patch, HIVE-6185.patch,
HIVE-6185.patch
>
>
> When creating a table, Hive uses URI to represent location:
> {code}
>     if (crtTbl.getLocation() != null) {
>       tbl.setDataLocation(new Path(crtTbl.getLocation()).toUri());
>     }
> {code}
> When adding a partition, Hive uses Path to represent location:
> {code}
>       // set partition path relative to table
>       db.createPartition(tbl, addPartitionDesc.getPartSpec(), new Path(tbl
>                     .getPath(), addPartitionDesc.getLocation()), addPartitionDesc.getPartParams(),
>                     addPartitionDesc.getInputFormat(),
>                     addPartitionDesc.getOutputFormat(),
>                     addPartitionDesc.getNumBuckets(),
>                     addPartitionDesc.getCols(),
>                     addPartitionDesc.getSerializationLib(),
>                     addPartitionDesc.getSerdeParams(),
>                     addPartitionDesc.getBucketCols(),
>                     addPartitionDesc.getSortCols());
> {code}
> This disparity makes the values stored in metastore be encoded differently, causing problems
w.r.t. special character as demonstrated in HIVE-5446. As a result, the code dealing with
location for table is different for partition, creating maintenance burden.
> We need to standardize it to Path to be in line with other Path related cleanup effort.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message