hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-6115) Remove redundant code in HiveHBaseStorageHandler
Date Wed, 08 Jan 2014 23:30:50 GMT

    [ https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866051#comment-13866051
] 

Sushanth Sowmyan commented on HIVE-6115:
----------------------------------------

Having read through addResources order resolution a bit more, I believe the solution is to
have the following change:

{code}
     // check to see if this an input job or an outputjob
     if (this.configureInputJobProps) {
       try {
-        HBaseConfiguration.addHbaseResources(jobConf);
+        for (String k : jobProperties.keySet()){
+          jobConf.set(k, jobProperties.get(k));
+        }
         addHBaseDelegationToken(jobConf);
       }//try
       catch (IOException e) {
@@ -342,8 +341,6 @@ public void configureTableJobProperties(
       } //input job properties
     }
     else {
-      Configuration copyOfConf = new Configuration(jobConf);
-      HBaseConfiguration.addHbaseResources(copyOfConf);
       jobProperties.put(TableOutputFormat.OUTPUT_TABLE, tableName);
     } // output job properties
   }
{code}

> Remove redundant code in HiveHBaseStorageHandler
> ------------------------------------------------
>
>                 Key: HIVE-6115
>                 URL: https://issues.apache.org/jira/browse/HIVE-6115
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.12.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: HIVE-6115.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message