hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan (JIRA)" <>
Subject [jira] [Commented] (HIVE-6115) Remove redundant code in HiveHBaseStorageHandler
Date Mon, 06 Jan 2014 21:37:51 GMT


Sushanth Sowmyan commented on HIVE-6115:

Hi guys,

Looking through the code, there are two signatures for calls on addHbaseResources, one being
addHBaseResources(Configuration,Map<String,String>) and the other being addHBaseResources(Configuration).
The first function is implemented in the HiveHBaseStorageHandler itself, and the other is
defined in HBaseConfiguration.

The one in HBaseConfiguration does the following:

   * adds resources (hbase config xmls) to the conf passed in to it
   * performs some checks.

The one in HiveHBaseStorageHandler does the following:

  * instantiates a new conf, and runs HBaseConfiguration.addHBaseResources on it.
  * Then, iterates through its properties, and for all values in it that are null (i.e. not
present - covers only adds, not updates) in jobconf, it copies them into the Map<String,String>

So, our code path is relevant for the input side, where if called from hcatalog, we should
be updating jobconf itself as well, so the extra bit makes sense. On the output side, however,
where we do a copy into a copyOfConf, that looks redundant.

> Remove redundant code in HiveHBaseStorageHandler
> ------------------------------------------------
>                 Key: HIVE-6115
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.12.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: HIVE-6115.patch

This message was sent by Atlassian JIRA

View raw message