hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohammad Islam" <misla...@yahoo.com>
Subject Re: Review Request 11925: Hive-3159 Update AvroSerde to determine schema of new tables
Date Fri, 31 Jan 2014 02:18:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11925/
-----------------------------------------------------------

(Updated Jan. 31, 2014, 2:18 a.m.)


Review request for hive, Ashutosh Chauhan and Jakob Homan.


Changes
-------

Addressed Carl's review comments


Bugs: HIVE-3159
    https://issues.apache.org/jira/browse/HIVE-3159


Repository: hive-git


Description
-------

Problem:
Hive doesn't support to create a Avro-based table using HQL create table command. It currently
requires to specify Avro schema literal or schema file name.
For multiple cases, it is very inconvenient for user.
Some of the un-supported use cases:
1. Create table ... <Avro-SERDE etc.> as SELECT ... from <NON-AVRO FILE>
2. Create table ... <Avro-SERDE etc.> as SELECT from <AVRO TABLE>
3. Create  table  without specifying Avro schema.


Diffs (updated)
-----

  ql/src/test/queries/clientpositive/avro_create_as_select.q PRE-CREATION 
  ql/src/test/queries/clientpositive/avro_nested_complex.q PRE-CREATION 
  ql/src/test/queries/clientpositive/avro_nullable_fields.q f90ceb9 
  ql/src/test/queries/clientpositive/avro_without_schema.q PRE-CREATION 
  ql/src/test/results/clientpositive/avro_create_as_select.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/avro_nested_complex.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/avro_nullable_fields.q.out 81950b0 
  ql/src/test/results/clientpositive/avro_without_schema.q.out PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java 9d58d13 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerdeUtils.java 67d5570 
  serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java PRE-CREATION


Diff: https://reviews.apache.org/r/11925/diff/


Testing
-------

Wrote a new java Test class for a new Java class. Added a new test case into existing java
test class. In addition, there are 4 .q file for testing multiple use-cases.


Thanks,

Mohammad Islam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message