hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swarnim Kulkarni" <kulkarni.swar...@gmail.com>
Subject Re: Review Request 17441: Adds concept of root role in Hive.
Date Wed, 29 Jan 2014 06:14:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17441/#review33049
-----------------------------------------------------------



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17441/#comment62367>

    Might be helpful to log a debug message here.



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17441/#comment62269>

    Nit: Should this be a WARN or ERROR?



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17441/#comment62364>

    Would it still make sense to make that check here and throw an AssertionError?



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17441/#comment62366>

    Nit: Instead of manually concatenating, this could simply be:
    
    LOG.info("No user is added in root role, since config value {} is in incorrect format",
userStr).
    
    Similar comment for other LOG statements.


- Swarnim Kulkarni


On Jan. 29, 2014, 1:31 a.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17441/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 1:31 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-5959
>     https://issues.apache.org/jira/browse/HIVE-5959
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Adds concept of root role in Hive.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 84ee78f 
>   conf/hive-default.xml.template 66d22f9 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAdminUser.java
PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58f9957 
> 
> Diff: https://reviews.apache.org/r/17441/diff/
> 
> 
> Testing
> -------
> 
> New junit test added.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message