hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan" <hashut...@apache.org>
Subject Re: Review Request 17441: Adds concept of root role in Hive.
Date Tue, 28 Jan 2014 21:17:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17441/
-----------------------------------------------------------

(Updated Jan. 28, 2014, 9:17 p.m.)


Review request for hive and Thejas Nair.


Changes
-------

* Rebased on latest trunk (on top HIVE-5929)
* Added new property in hive-default.xml.template
* Added indirect test to make sure users from config are getting added in admin role. Indirect
because currently there is no easy way to list role membership. This will be available in
future though, since it will be required by describe role syntax too. So, currently added
test to revoke admin role from that user. Also, verified from logs that users are getting
added to admin role. 
* Fixed various indentations.
* Fixed log levels.
* Incorporated other feedback.


Bugs: HIVE-5959
    https://issues.apache.org/jira/browse/HIVE-5959


Repository: hive-git


Description
-------

Adds concept of root role in Hive.


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 84ee78f 
  conf/hive-default.xml.template 66d22f9 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAdminUser.java PRE-CREATION

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58f9957 

Diff: https://reviews.apache.org/r/17441/diff/


Testing
-------

New junit test added.


Thanks,

Ashutosh Chauhan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message