hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jitendra Pandey" <jiten...@hortonworks.com>
Subject Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.
Date Mon, 27 Jan 2014 23:26:47 GMT


> On Jan. 27, 2014, 6:54 p.m., Eric Hanson wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java, line 1126
> > <https://reviews.apache.org/r/17005/diff/2/?file=450612#file450612line1126>
> >
> >     For safety, you could put a check here and throw an exception if scratchScaleVector.vector[I]
is not equal to result.vector[I].scale.
> >     
> >     Alternatively, you could make the value NULL if that is the case, and maybe
log an error.

The code in the latest patch re-scales the decimal value to the expected scale if there is
a mismatch.


- Jitendra


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17005/#review32855
-----------------------------------------------------------


On Jan. 27, 2014, 11:20 p.m., Jitendra Pandey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17005/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 11:20 p.m.)
> 
> 
> Review request for hive and Eric Hanson.
> 
> 
> Bugs: HIVE-6178
>     https://issues.apache.org/jira/browse/HIVE-6178
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> vectorized reader for DECIMAL datatype for ORC format.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java 15025cf 
>   common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java d71ebb3 
>   common/src/test/org/apache/hadoop/hive/common/type/TestUnsignedInt128.java fbb2aa0

>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/DecimalColumnVector.java 23564bb

>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 0df82b9 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedORCReader.java 0d5b7ff 
> 
> Diff: https://reviews.apache.org/r/17005/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jitendra Pandey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message