hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Re: Review Request 17162: HIVE-6157 Fetching column stats slow
Date Mon, 27 Jan 2014 20:01:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17162/#review32861
-----------------------------------------------------------



metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
<https://reviews.apache.org/r/17162/#comment61867>

    are there 12 columns in column stats table? can 12 be made as a static const?



ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java
<https://reviews.apache.org/r/17162/#comment61870>

    Is there any reason why this additional map conversion is needed? If neededColumns is
not empty then it can be returned else iterate the schema and ignore the virtual columns.
    
    if(neededColumns.isEmpty()) {
     return list of non-hidden/vitual columns from schema;
    } else {
    return neededColumns;
    }


- Prasanth_J


On Jan. 23, 2014, 7:53 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17162/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 7:53 p.m.)
> 
> 
> Review request for hive and Gunther Hagleitner.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
1b01238 
>   metastore/if/hive_metastore.thrift e4e816d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58f9957 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java ed05790

>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 4288781 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 16f43e9

>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 794fadd 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java f5ea2ef 
>   metastore/src/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java PRE-CREATION

>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
003dc9c 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
6dd0852 
>   metastore/src/test/org/apache/hadoop/hive/metastore/VerifyingObjectStore.java c683fc9

>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java d32deea 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java 608bef2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java b815ea2 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 384b49e 
>   ql/src/test/results/clientpositive/metadataonly1.q.out 3500fd2 
> 
> Diff: https://reviews.apache.org/r/17162/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message