hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohammad Islam" <misla...@yahoo.com>
Subject Re: Review Request 17262: HIVE-6246: Sign(a) UDF is not supported for decimal type
Date Mon, 27 Jan 2014 19:49:14 GMT


> On Jan. 23, 2014, 10:57 p.m., Mohammad Islam wrote:
> > Overall looks good.
> > Is it possible to add a .q test or append to an existing .q test?
> 
> Xuefu Zhang wrote:
>     Actually unit test such as that provided is preferrable. Additional .q test only
prelongs the build process while not providing much value for this case.

ok with me. I agree the build-timing is important. but, in some instances,i found people prefer
.q test.


> On Jan. 23, 2014, 10:57 p.m., Mohammad Islam wrote:
> > ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFSign.java, line 31
> > <https://reviews.apache.org/r/17262/diff/1/?file=436440#file436440line31>
> >
> >     Minor issue: does testByte() is a good name?
> 
> Xuefu Zhang wrote:
>     A result of C&P. Will change it.

sounds good.


- Mohammad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17262/#review32677
-----------------------------------------------------------


On Jan. 23, 2014, 8:57 p.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17262/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 8:57 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6246
>     https://issues.apache.org/jira/browse/HIVE-6246
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Please see the JIRA description. It's believed that this has nevered worked. Added a
method in UDFSign class to handle Decimal data type to make it work. This method returns INT
instead of doulbe to be inline with other data bases.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 729908a 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSign.java 0fef283 
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFSign.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17262/diff/
> 
> 
> Testing
> -------
> 
> Unit test is added.
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message