hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere" <jd...@hortonworks.com>
Subject Review Request 17302: HIVE-6012: restore backward compatibility of arithmetic operations
Date Fri, 24 Jan 2014 02:54:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17302/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-6012
    https://issues.apache.org/jira/browse/HIVE-6012


Repository: hive-git


Description
-------

Change return types back to Hive-0.12 behavior for the following math operators:
int / int -> decimal, used to be double in Hive-0.12
float + int -> double, used to be float in Hive-0.12
float + float -> double, used to be float in Hive-0.12
float * int -> double, used to be float in Hive-0.12
float * float -> double, used to be float in Hive-0.12


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 371cb0f 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java 28b5ffd 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java 9a04e81 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java e894b54 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java d7285d9 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java ef17eb5 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java 56472f0

  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPNumeric.java PRE-CREATION

  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java 6193257 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java 702e3e7 

Diff: https://reviews.apache.org/r/17302/diff/


Testing
-------


Thanks,

Jason Dere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message