hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohammad Islam" <misla...@yahoo.com>
Subject Re: Review Request 17262: HIVE-6246: Sign(a) UDF is not supported for decimal type
Date Thu, 23 Jan 2014 22:57:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17262/#review32677
-----------------------------------------------------------


Overall looks good.
Is it possible to add a .q test or append to an existing .q test? 


ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFSign.java
<https://reviews.apache.org/r/17262/#comment61610>

    Minor issue: does testByte() is a good name?


- Mohammad Islam


On Jan. 23, 2014, 8:57 p.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17262/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 8:57 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6246
>     https://issues.apache.org/jira/browse/HIVE-6246
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Please see the JIRA description. It's believed that this has nevered worked. Added a
method in UDFSign class to handle Decimal data type to make it work. This method returns INT
instead of doulbe to be inline with other data bases.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 729908a 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSign.java 0fef283 
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFSign.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17262/diff/
> 
> 
> Testing
> -------
> 
> Unit test is added.
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message