hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohammad Islam" <misla...@yahoo.com>
Subject Re: Review Request 17217: HIVE-???? MSCK can be slow when adding partitions
Date Thu, 23 Jan 2014 03:14:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17217/#review32592
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/17217/#comment61495>

    Should we clear repairOutput list before the loop? The reason: there is a very small possibility
that 'repairOutput' is partially populated in the caller method before the exception thrown.
     



ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/17217/#comment61496>

    Is it the same 'db' object that might be populated in the caller method?


- Mohammad Islam


On Jan. 23, 2014, 12:49 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17217/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 12:49 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Gunther Hagleitner.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> JIRA is reindexing so I will file the JIRA later.
> 
> Trivial patch. Use bulk method.
> If bulk method fails try one by one (via existing code), it's msck after all so we expect
the worst.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 92ed55b 
> 
> Diff: https://reviews.apache.org/r/17217/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message