hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis Ryu" <navis....@nexr.com>
Subject Re: Review Request 15449: session/operation timeout for hiveserver2
Date Wed, 22 Jan 2014 04:41:44 GMT


> On Nov. 15, 2013, 9:21 a.m., Carl Steinbach wrote:
> > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java, line
397
> > <https://reviews.apache.org/r/15449/diff/2/?file=382968#file382968line397>
> >
> >     Can we change the name to something like closeExpiredOperations()?

I think other things can be done here not just checking expiring.


> On Nov. 15, 2013, 9:21 a.m., Carl Steinbach wrote:
> > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java, line
405
> > <https://reviews.apache.org/r/15449/diff/2/?file=382968#file382968line405>
> >
> >     Is this actually necessary or is it a hypothetical bug you're guarding against?
Is it possible to get rid of opHandleSet and push most of this logic down into OperationManager?

It's not introduced by this issue. But I moved logic itself to operation manager.


- Navis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15449/#review28950
-----------------------------------------------------------


On Nov. 18, 2013, 2:32 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15449/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2013, 2:32 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5799
>     https://issues.apache.org/jira/browse/HIVE-5799
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Need some timeout facility for preventing resource leakages from instable or bad clients.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32ab3d8 
>   conf/hive-default.xml.template c574ab5 
>   service/src/java/org/apache/hive/service/cli/OperationState.java 1ec6bd1 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 6f4b8dc 
>   service/src/java/org/apache/hive/service/cli/session/HiveSession.java 00058cc 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java cfda752 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java e262b72 
> 
> Diff: https://reviews.apache.org/r/15449/diff/
> 
> 
> Testing
> -------
> 
> Confirmed in the local environment.
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message