hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "shanyu zhao" <shz...@microsoft.com>
Subject Review Request 17084: Windows: percentComplete returned by job status from WebHCat is null
Date Sat, 18 Jan 2014 02:08:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17084/
-----------------------------------------------------------

Review request for hive, Eugene Koifman, Eric Hanson, and Thejas Nair.


Bugs: HIVE-6035
    https://issues.apache.org/jira/browse/HIVE-6035


Repository: hive-git


Description
-------

HIVE-5511 fixed the same problem on Linux, but it still broke on Windows.

The root cause of this problem is that the -Dlog4j.configuration needs to be in the format
of "file://d:/xxx", so:
 "file://" + log4jProps.getAbsolutePath()
 works on Linux but does not work on Windows because it will produce "file://d:\xxx".

This patch fixed two problem:
 1) templeton.cmd correctly set WEBHCAT_CONF_DIR so that override_container_log4j.properties
can be copied to distributed cache. I also modified it so that one can run timepleton.cmd
(without any parameter) in standalone mode.
 2) use hadoop class Path to convert the override log4j properties file path, the Path class
will convert the platform specific path into uri style.


Diffs
-----

  hcatalog/bin/templeton.cmd dcb976e 
  hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TrivialExecService.java
73892cc 

Diff: https://reviews.apache.org/r/17084/diff/


Testing
-------


Thanks,

shanyu zhao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message