hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere" <jd...@hortonworks.com>
Subject Review Request 16921: HIVE-6208 user-defined aggregate functions cannot be used as windowing function
Date Wed, 15 Jan 2014 21:58:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16921/
-----------------------------------------------------------

Review request for hive and Harish Butani.


Bugs: HIVE-6208
    https://issues.apache.org/jira/browse/HIVE-6208


Repository: hive-git


Description
-------

- All UDAFs are also added to window function list when registered to function registry
- Avoid NPE when invalid function name used as window function


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 96a78fc 
  ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java f011258 
  ql/src/test/queries/clientnegative/windowing_invalid_udaf.q PRE-CREATION 
  ql/src/test/queries/clientpositive/windowing_udaf2.q PRE-CREATION 
  ql/src/test/results/clientnegative/windowing_invalid_udaf.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/windowing_udaf2.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/16921/diff/


Testing
-------

Added positive/negative test


Thanks,

Jason Dere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message