hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar" <pras...@cloudera.com>
Subject Re: Review Request 16593: HIVE-3611: Hive JDBC doesn't support BINARY column
Date Tue, 14 Jan 2014 06:26:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16593/#review31706
-----------------------------------------------------------


Overall looks fine, a couple of minor comments below


jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java
<https://reviews.apache.org/r/16593/#comment60438>

    This is already handled on line #119 ?



jdbc/src/java/org/apache/hive/jdbc/Utils.java
<https://reviews.apache.org/r/16593/#comment60442>

    do we need this ? it's already checked just above


- Prasad Mujumdar


On Jan. 3, 2014, 12:42 a.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16593/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 12:42 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-3611
>     https://issues.apache.org/jira/browse/HIVE-3611
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added BINARY data type support in JDBC2.
> 
> 
> Diffs
> -----
> 
>   data/files/datatypes.txt 1e48c8d 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 4090e72 
>   jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java b02f374 
>   jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java 3116100 
>   jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java e89571f 
>   jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java 42ec32a 
>   jdbc/src/java/org/apache/hive/jdbc/Utils.java 913dc46 
> 
> Diff: https://reviews.apache.org/r/16593/diff/
> 
> 
> Testing
> -------
> 
> Changed existing test cases to include binary data type in TestJdbcDriver2.
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message