hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis Ryu" <navis....@nexr.com>
Subject Re: Review Request 16643: SQL std auth - support 'show all roles'
Date Mon, 13 Jan 2014 01:40:18 GMT


> On Jan. 6, 2014, 7:49 a.m., Thejas Nair wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 792
> > <https://reviews.apache.org/r/16643/diff/1/?file=416130#file416130line792>
> >
> >     I think we should skip the "role name:" in the output, similar to the change
you made in different jira for 'show role grant'

Done. The output format you've mentioned was handled in following issue (in my dev tree),
making it option for output format. But's it looks trivial enough.


> On Jan. 6, 2014, 7:49 a.m., Thejas Nair wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 795
> > <https://reviews.apache.org/r/16643/diff/1/?file=416130#file416130line795>
> >
> >     this cast should not be needed. Not sure why it came to be used in other places
in this class.
> >

Ok. I'll find things like this and removed them all. 


- Navis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16643/#review31225
-----------------------------------------------------------


On Jan. 13, 2014, 1:40 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16643/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 1:40 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5941
>     https://issues.apache.org/jira/browse/HIVE-5941
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> SHOW ALL ROLES - This will list all
> currently existing roles. This will be available only to the superuser.
> This task includes parser changes.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9e4f1c7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 713bd54 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g da745d7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 5dff3fe 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 9b6fc3b 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 542d59a 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java bfd6b77 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java 99dadb0 
>   ql/src/test/queries/clientpositive/show_roles.q PRE-CREATION 
>   ql/src/test/results/clientpositive/show_roles.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16643/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message