hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin" <ser...@hortonworks.com>
Subject Re: Review Request 16747: Add file pruning into Hive
Date Fri, 10 Jan 2014 18:02:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16747/#review31518
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/16747/#comment60028>

    why make it a hashset now? or should it have always been one



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/16747/#comment60029>

    nit: could return Collection from the method if it's not hard to change



ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java
<https://reviews.apache.org/r/16747/#comment60030>

    what is the form of the path here? just checking, in case it contains protocol prefix,
or may start w/"/"



ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java
<https://reviews.apache.org/r/16747/#comment60031>

    why is it recreating the list? maybe use addAll if it is needed?



ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java
<https://reviews.apache.org/r/16747/#comment60032>

    javadoc for these methods? Here and above/below at least a little description if not params
:)



ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java
<https://reviews.apache.org/r/16747/#comment60033>

    is it possible to use 3 proper fields?


- Sergey Shelukhin


On Jan. 9, 2014, 2:19 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16747/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 2:19 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-1662
>     https://issues.apache.org/jira/browse/HIVE-1662
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> now hive support filename virtual column. 
> if a file name filter presents in a query, hive should be able to only add files which
passed the filter to input paths.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3bfd539 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 96a78fc 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7dc3d59 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 42d764d 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java a7e2253 
>   ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java e66c22c 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java 4be56f3 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 99172d4 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/FilePrunningPredicateHandler.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStoragePredicateHandler.java 9f35575

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
33ef581 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
5c6751c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/MapReduceCompiler.java 76f5a31 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java 96c8d89 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 9929275 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java f3203bf 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java da1437c 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 9c35890 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 40298e1 
>   ql/src/test/queries/clientpositive/file_pruning.q PRE-CREATION 
>   ql/src/test/results/clientpositive/file_pruning.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16747/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message