hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 16727: Review Board for HIVE-5446 Hive can CREATE an external table but not SELECT from it when file path have spaces
Date Thu, 09 Jan 2014 03:51:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16727/#review31426
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java
<https://reviews.apache.org/r/16727/#comment59911>

    I think we need to take care of this code path as well. Is there any justification for
not worry about it? This was brought up in previous review comments.



ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java
<https://reviews.apache.org/r/16727/#comment59910>

    I think we we need to be consistent here. Returning null seems more appropriate. In any
case, logging a meaningful message is helpful.


- Xuefu Zhang


On Jan. 9, 2014, 1:57 a.m., Shuaishuai Nie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16727/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 1:57 a.m.)
> 
> 
> Review request for hive, Thejas Nair and Xuefu Zhang.
> 
> 
> Bugs: HIVE-5446
>     https://issues.apache.org/jira/browse/HIVE-5446
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Hive cannot select from external table with location has "+" or space in the path
> 
> 
> Diffs
> -----
> 
>   data/files/ext_test_space/folder+with PRE-CREATION 
>   itests/qtest/pom.xml 119ddb5 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 0fe260d 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 877d342 
>   ql/src/test/queries/clientpositive/external_table_with_space_in_location_path.q PRE-CREATION

>   ql/src/test/results/clientpositive/external_table_with_space_in_location_path.q.out
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16727/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shuaishuai Nie
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message