hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Review Request 16565: HIVE-5923 - SQL std auth - parser changes
Date Thu, 02 Jan 2014 06:57:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16565/
-----------------------------------------------------------

Review request for hive and Brock Noland.


Repository: hive-git


Description
-------

Grant privilege and revoke privilege statements need to be changed to remove the requirement
(but not the option) for the noise word TABLE. In the SQL specification table is the assumed
default for grant and revoke statements. Today Hive’s syntax is GRANT action ON TABLE table
TO grantee. It should be GRANT action ON [TABLE] table TO grantee.

Grant role and revoke role statements has been changed to remove the need for keyword ROLE.


Support for WITH ADMIN OPTION needs to be added to grant role and revoke role statement syntax.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 8d0b7a8 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java a1b19a6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 9354637 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g b34f53b 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 39d53d3 
  ql/src/java/org/apache/hadoop/hive/ql/plan/PrivilegeObjectDesc.java f0acb16 
  ql/src/test/queries/clientpositive/authorization_2.q 4fc79b9 
  ql/src/test/queries/clientpositive/authorization_role_grant1.q PRE-CREATION 
  ql/src/test/results/clientpositive/authorization_2.q.out 460240b 
  ql/src/test/results/clientpositive/authorization_role_grant1.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/16565/diff/


Testing
-------


Thanks,

Thejas Nair


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message