Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CCA551044B for ; Mon, 30 Dec 2013 17:33:02 +0000 (UTC) Received: (qmail 79850 invoked by uid 500); 30 Dec 2013 17:32:55 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 79782 invoked by uid 500); 30 Dec 2013 17:32:53 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 79758 invoked by uid 500); 30 Dec 2013 17:32:51 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 79752 invoked by uid 99); 30 Dec 2013 17:32:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Dec 2013 17:32:51 +0000 Date: Mon, 30 Dec 2013 17:32:51 +0000 (UTC) From: "Brock Noland (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-6112) SQL std auth - support new privileges INSERT, DELETE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858946#comment-13858946 ] Brock Noland commented on HIVE-6112: ------------------------------------ Looks like this patch misses the getPrivTypeByName() and the toString() method on Privilege. FIWW this class looks like a perfect candidate for a unit test and I think we could get ride of all those if/else and case statements by storing this stuff in a map. > SQL std auth - support new privileges INSERT, DELETE > ---------------------------------------------------- > > Key: HIVE-6112 > URL: https://issues.apache.org/jira/browse/HIVE-6112 > Project: Hive > Issue Type: Sub-task > Components: Authorization > Reporter: Thejas M Nair > Attachments: new-privs.patch > > Original Estimate: 12h > Remaining Estimate: 12h > > Includes INSERT, DELETE privileges. -- This message was sent by Atlassian JIRA (v6.1.5#6160)