Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6277A10C64 for ; Sat, 21 Dec 2013 21:22:10 +0000 (UTC) Received: (qmail 8483 invoked by uid 500); 21 Dec 2013 21:22:09 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 8415 invoked by uid 500); 21 Dec 2013 21:22:09 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 8400 invoked by uid 500); 21 Dec 2013 21:22:09 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 8397 invoked by uid 99); 21 Dec 2013 21:22:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Dec 2013 21:22:09 +0000 Date: Sat, 21 Dec 2013 21:22:09 +0000 (UTC) From: "Brock Noland (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-5843) Transaction manager for Hive MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854941#comment-13854941 ] Brock Noland commented on HIVE-5843: ------------------------------------ Alan, Can you generate a patch which does not contain the generated code for reviewing purposes? Also, you thrift methods should take a single request object and return a single response object so the methods can be versioned. HS2 does a good job of this: https://github.com/apache/hive/blob/trunk/service/if/TCLIService.thrift#L1020 > Transaction manager for Hive > ---------------------------- > > Key: HIVE-5843 > URL: https://issues.apache.org/jira/browse/HIVE-5843 > Project: Hive > Issue Type: Sub-task > Affects Versions: 0.12.0 > Reporter: Alan Gates > Assignee: Alan Gates > Fix For: 0.13.0 > > Attachments: HIVE-5843.2.patch, HIVE-5843.patch, HiveTransactionManagerDetailedDesign (1).pdf > > > As part of the ACID work proposed in HIVE-5317 a transaction manager is required. -- This message was sent by Atlassian JIRA (v6.1.4#6159)