Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1108F105B0 for ; Fri, 6 Dec 2013 07:01:07 +0000 (UTC) Received: (qmail 21522 invoked by uid 500); 6 Dec 2013 04:07:39 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 21472 invoked by uid 500); 6 Dec 2013 04:07:38 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 21449 invoked by uid 500); 6 Dec 2013 04:07:37 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 21429 invoked by uid 99); 6 Dec 2013 04:07:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Dec 2013 04:07:36 +0000 Date: Fri, 6 Dec 2013 04:07:36 +0000 (UTC) From: "Phabricator (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840943#comment-13840943 ] Phabricator commented on HIVE-2093: ----------------------------------- thejas has commented on the revision "HIVE-2093 [jira] create/drop database should populate inputs/outputs and check concurrency and user permission". I have reviewed half of it, looks good mostly. I will complete the review tomorrow. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/Driver.java:510 What is the basis of the SQLState value ? what does it mean? Isn't class 01 warning ? But this is an error. ql/src/java/org/apache/hadoop/hive/ql/Driver.java:737 can you update the javadoc for this param ? REVISION DETAIL https://reviews.facebook.net/D12807 To: JIRA, navis Cc: thejas > create/drop database should populate inputs/outputs and check concurrency and user permission > --------------------------------------------------------------------------------------------- > > Key: HIVE-2093 > URL: https://issues.apache.org/jira/browse/HIVE-2093 > Project: Hive > Issue Type: Bug > Components: Authorization, Locking, Metastore, Security > Reporter: Namit Jain > Assignee: Navis > Attachments: D12807.3.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch > > > concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1#6144)