Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D467D10AC0 for ; Mon, 30 Dec 2013 22:41:23 +0000 (UTC) Received: (qmail 84900 invoked by uid 500); 30 Dec 2013 22:41:23 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 84851 invoked by uid 500); 30 Dec 2013 22:41:23 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 84840 invoked by uid 99); 30 Dec 2013 22:41:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Dec 2013 22:41:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3A9101D410E; Mon, 30 Dec 2013 22:41:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7696208695416174361==" MIME-Version: 1.0 Subject: Re: Review Request 16184: Hive should be able to skip header and footer rows when reading data file for a table (HIVE-5795) From: "Shuaishuai Nie" To: "Eric Hanson" , "Thejas Nair" Cc: "hive" , "Shuaishuai Nie" Date: Mon, 30 Dec 2013 22:41:21 -0000 Message-ID: <20131230224121.21727.5085@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Shuaishuai Nie" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/16184/ X-Sender: "Shuaishuai Nie" References: <20131219004029.6473.72784@reviews.apache.org> In-Reply-To: <20131219004029.6473.72784@reviews.apache.org> Reply-To: "Shuaishuai Nie" X-ReviewRequest-Repository: hive-git --===============7696208695416174361== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16184/ ----------------------------------------------------------- (Updated Dec. 30, 2013, 10:41 p.m.) Review request for hive, Eric Hanson and Thejas Nair. Changes ------- Fixed the patch based on Thejas's comment Bugs: hive-5795 https://issues.apache.org/jira/browse/hive-5795 Repository: hive-git Description ------- Hive should be able to skip header and footer rows when reading data file for a table (follow up with review https://reviews.apache.org/r/15663/diff/#index_header) Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2ddb08f conf/hive-default.xml.template b94013a data/files/header_footer_table_1/0001.txt PRE-CREATION data/files/header_footer_table_1/0002.txt PRE-CREATION data/files/header_footer_table_1/0003.txt PRE-CREATION data/files/header_footer_table_2/2012/01/01/0001.txt PRE-CREATION data/files/header_footer_table_2/2012/01/02/0002.txt PRE-CREATION data/files/header_footer_table_2/2012/01/03/0003.txt PRE-CREATION itests/qtest/pom.xml 88e0890 itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 03fd30a ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java fc9b7e4 ql/src/java/org/apache/hadoop/hive/ql/exec/FooterBuffer.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java daf4e4a ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java dd5cb6b ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 974a5d6 ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java 85dd975 ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java 0686d9b ql/src/test/queries/clientnegative/file_with_header_footer_negative.q PRE-CREATION ql/src/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION ql/src/test/results/clientnegative/file_with_header_footer_negative.q.out PRE-CREATION ql/src/test/results/clientpositive/file_with_header_footer.q.out PRE-CREATION serde/if/serde.thrift 2ceb572 serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java 22a6168 Diff: https://reviews.apache.org/r/16184/diff/ Testing ------- Thanks, Shuaishuai Nie --===============7696208695416174361==--