Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0592610FD0 for ; Fri, 20 Dec 2013 03:26:50 +0000 (UTC) Received: (qmail 56428 invoked by uid 500); 20 Dec 2013 03:26:47 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 56275 invoked by uid 500); 20 Dec 2013 03:26:47 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 56251 invoked by uid 99); 20 Dec 2013 03:26:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Dec 2013 03:26:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B34D11D3FC5; Fri, 20 Dec 2013 03:26:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6831902884858164060==" MIME-Version: 1.0 Subject: Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF From: "Xuefu Zhang" To: "Carl Steinbach" , "Jitendra Pandey" , "Ashutosh Chauhan" Cc: "Xuefu Zhang" , "Mohammad Islam" , "hive" Date: Fri, 20 Dec 2013 03:26:44 -0000 Message-ID: <20131220032644.5702.32941@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xuefu Zhang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/15654/ X-Sender: "Xuefu Zhang" References: <20131220023719.5702.14888@reviews.apache.org> In-Reply-To: <20131220023719.5702.14888@reviews.apache.org> Reply-To: "Xuefu Zhang" X-ReviewRequest-Repository: hive-git --===============6831902884858164060== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Dec. 20, 2013, 2:37 a.m., Mohammad Islam wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseTrim.java, line 47 > > > > > > Even if I implement it this way won't I still have to cast arguments[0] to a PrimitiveObjectInspector in order to call getPrimitiveCategory()? If so then I don't see the advantage of doing it your way you suggest. Well, that just gives a little clean code without try... catch... block. The benefit is marginal, but personally I think it's better to do explicit check than relying on runtime exception. - Xuefu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15654/#review30732 ----------------------------------------------------------- On Dec. 18, 2013, 3:16 a.m., Mohammad Islam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15654/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2013, 3:16 a.m.) > > > Review request for hive, Ashutosh Chauhan, Carl Steinbach, and Jitendra Pandey. > > > Bugs: HIVE-5829 > https://issues.apache.org/jira/browse/HIVE-5829 > > > Repository: hive-git > > > Description > ------- > > Rewrite the UDFS *pads and *trim using GenericUDF. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java a895d65 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java bca1f26 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLTrim.java dc00cf9 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLpad.java d1da19a > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRTrim.java 2bcc5fa > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRpad.java 9652ce2 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFTrim.java 490886d > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseTrim.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLTrim.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLpad.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRTrim.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRpad.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrim.java PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java eff251f > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLTrim.java PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLpad.java PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFRTrim.java PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFRpad.java PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFTrim.java PRE-CREATION > > Diff: https://reviews.apache.org/r/15654/diff/ > > > Testing > ------- > > > Thanks, > > Mohammad Islam > > --===============6831902884858164060==--