Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 21C7E10BFA for ; Tue, 17 Dec 2013 05:34:32 +0000 (UTC) Received: (qmail 28802 invoked by uid 500); 17 Dec 2013 05:34:31 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 28658 invoked by uid 500); 17 Dec 2013 05:34:31 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 28643 invoked by uid 99); 17 Dec 2013 05:34:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Dec 2013 05:34:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2D5E01D3F60; Tue, 17 Dec 2013 05:34:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7635775906282462842==" MIME-Version: 1.0 Subject: Re: Review Request 15151: Better error reporting by async threads in HiveServer2 From: "Vaibhav Gumashta" To: "Prasad Mujumdar" , "Carl Steinbach" , "Thejas Nair" Cc: "Vaibhav Gumashta" , "hive" Date: Tue, 17 Dec 2013 05:34:29 -0000 Message-ID: <20131217053429.27244.70201@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vaibhav Gumashta" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/15151/ X-Sender: "Vaibhav Gumashta" References: <20131205001621.25728.79028@reviews.apache.org> In-Reply-To: <20131205001621.25728.79028@reviews.apache.org> Reply-To: "Vaibhav Gumashta" X-ReviewRequest-Repository: hive-git --===============7635775906282462842== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ ----------------------------------------------------------- (Updated Dec. 17, 2013, 5:34 a.m.) Review request for hive, Carl Steinbach, Prasad Mujumdar, and Thejas Nair. Changes ------- Rebased on trunk with thrift files. Bugs: HIVE-5230 https://issues.apache.org/jira/browse/HIVE-5230 Repository: hive-git Description ------- [HIVE-4617|https://issues.apache.org/jira/browse/HIVE-4617] provides support for async execution in HS2. When a background thread gets an error, currently the client can only poll for the operation state and also the error with its stacktrace is logged. However, it will be useful to provide a richer error response like thrift API does with TStatus (which is constructed while building a Thrift response object). Diffs (updated) ----- jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java e420b75 jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 37975e5 service/if/TCLIService.thrift 62a9730 service/src/gen/thrift/gen-cpp/TCLIService_types.h 853bb4c service/src/gen/thrift/gen-cpp/TCLIService_types.cpp 7ab1310 service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java 1c44789 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TColumn.java 497cc01 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetOperationStatusResp.java b5c3f01 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java 1cb5147 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionReq.java 8ab8297 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java 688f790 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java 8c6c4f0 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRow.java 0b6772c service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRowSet.java db2262d service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStatus.java 81c2f16 service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTableSchema.java ff5e54d service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeDesc.java 251f86a service/src/gen/thrift/gen-py/TCLIService/ttypes.py 185ea5b service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb c94acbf service/src/java/org/apache/hive/service/cli/CLIService.java 8c85386 service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 14ef54f service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9dca874 service/src/java/org/apache/hive/service/cli/ICLIService.java f647ce6 service/src/java/org/apache/hive/service/cli/OperationState.java 1ec6bd1 service/src/java/org/apache/hive/service/cli/OperationStatus.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/Operation.java 5d1dd5f service/src/java/org/apache/hive/service/cli/operation/OperationManager.java bcdb67f service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 296f8b3 service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java c0e6151 service/src/java/org/apache/hive/service/cli/session/SessionManager.java e262b72 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 9df110e service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 9bb2a0f service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 44d3130 service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d Diff: https://reviews.apache.org/r/15151/diff/ Testing ------- Thanks, Vaibhav Gumashta --===============7635775906282462842==--