Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============8377893623069857750=="
MIME-Version: 1.0
Subject: Re: Review Request 16053: HIVE-5966: Fix eclipse:eclipse post shim
 aggregation changes
From: "Brock Noland" <brock@cloudera.com>
To: "Szehon Ho" <szehon@cloudera.com>, "hive" <dev@hive.apache.org>,
 "Brock Noland" <brock@cloudera.com>
Date: Fri, 06 Dec 2013 03:14:32 -0000
Message-ID: <20131206031432.12251.25570@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Brock Noland" <noreply@reviews.apache.org>
References: <20131206021346.12251.50157@reviews.apache.org>
In-Reply-To: <20131206021346.12251.50157@reviews.apache.org>
Reply-To: "Brock Noland" <brock@cloudera.com>

--===============8377893623069857750==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16053/#review29868
-----------------------------------------------------------

Ship it!


Ship It!

- Brock Noland


On Dec. 6, 2013, 2:13 a.m., Szehon Ho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16053/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2013, 2:13 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5966
>     https://issues.apache.org/jira/browse/HIVE-5966
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> After shims aggregator changes, mvn install would work because all projects had dependency to the hadoop-shims uberjar, but eclipse plugin fails because it did not understand that dependency.
> 
> This patch eliminates the shims uberjar and replacing it with an shims-aggregator project, so that both mvn eclipse:eclipse and mvn install will work.
> 
> Chose only shims-common and shims-common-secure as compile time dependency in new shims-aggregator project, the shims-version are runtime dependency.  The hive projects are already declaring explicit compile-time dependencies to shims-version dependencies.  (In fact, maybe we dont even need dependency from shims-aggregator to shims-version?)
> 
> 
> Diffs
> -----
> 
>   ql/pom.xml fc65608 
>   shims/aggregator/pom.xml PRE-CREATION 
>   shims/assembly/pom.xml a03ebff 
>   shims/assembly/src/assemble/uberjar.xml 3eba66d 
>   shims/pom.xml 8c14d9b 
> 
> Diff: https://reviews.apache.org/r/16053/diff/
> 
> 
> Testing
> -------
> 
> Basic sanity tests with hadoop-2 profile:
> 
> Compiled and imported projects to eclipse, verified no error.
> Ran a qfile test.
> Built the assembly and ran a basic MR query.
> 
> 
> Thanks,
> 
> Szehon Ho
> 
>


--===============8377893623069857750==--