Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0B62410484 for ; Thu, 5 Dec 2013 05:06:18 +0000 (UTC) Received: (qmail 56601 invoked by uid 500); 5 Dec 2013 05:06:16 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 56550 invoked by uid 500); 5 Dec 2013 05:06:14 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 56538 invoked by uid 99); 5 Dec 2013 05:06:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Dec 2013 05:06:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4BB1C1D3D02; Thu, 5 Dec 2013 05:06:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1663467098369244064==" MIME-Version: 1.0 Subject: Re: Review Request 16026: No need to aggregate statistics collected via counter mechanism From: "Ashutosh Chauhan" To: "Navis Ryu" Cc: "Ashutosh Chauhan" , "hive" Date: Thu, 05 Dec 2013 05:06:08 -0000 Message-ID: <20131205050608.12251.25118@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ashutosh Chauhan" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/16026/ X-Sender: "Ashutosh Chauhan" References: <20131205010145.12251.55451@reviews.apache.org> In-Reply-To: <20131205010145.12251.55451@reviews.apache.org> Reply-To: "Ashutosh Chauhan" X-ReviewRequest-Repository: hive --===============1663467098369244064== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16026/ ----------------------------------------------------------- (Updated Dec. 5, 2013, 5:06 a.m.) Review request for hive and Navis Ryu. Changes ------- Addressed comments. Bugs: HIVE-5916 https://issues.apache.org/jira/browse/HIVE-5916 Repository: hive Description ------- No need to aggregate statistics collected via counter mechanism Diffs (updated) ----- trunk/itests/qtest/pom.xml 1548014 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1548014 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1548014 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 1548014 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1548014 trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java 1548014 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1548014 trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java 1548014 trunk/ql/src/test/queries/clientpositive/stats_counter_partitioned.q PRE-CREATION trunk/ql/src/test/results/clientpositive/stats12.q.out 1548014 trunk/ql/src/test/results/clientpositive/stats13.q.out 1548014 trunk/ql/src/test/results/clientpositive/stats_counter_partitioned.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16026/diff/ Testing ------- Added a new test case. Ran all other stats test. Thanks, Ashutosh Chauhan --===============1663467098369244064==--