Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A9B5210335 for ; Thu, 5 Dec 2013 04:29:41 +0000 (UTC) Received: (qmail 10977 invoked by uid 500); 5 Dec 2013 04:29:37 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 10911 invoked by uid 500); 5 Dec 2013 04:29:30 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 10893 invoked by uid 99); 5 Dec 2013 04:29:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Dec 2013 04:29:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1627A1D3D02; Thu, 5 Dec 2013 04:29:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4480865150049906451==" MIME-Version: 1.0 Subject: Re: Review Request 16026: No need to aggregate statistics collected via counter mechanism From: "Ashutosh Chauhan" To: "Navis Ryu" Cc: "Ashutosh Chauhan" , "hive" Date: Thu, 05 Dec 2013 04:29:20 -0000 Message-ID: <20131205042920.25728.87602@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ashutosh Chauhan" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/16026/ X-Sender: "Ashutosh Chauhan" References: <20131205035907.12251.95808@reviews.apache.org> In-Reply-To: <20131205035907.12251.95808@reviews.apache.org> Reply-To: "Ashutosh Chauhan" X-ReviewRequest-Repository: hive --===============4480865150049906451== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Dec. 5, 2013, 3:59 a.m., Navis Ryu wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java, line 978 > > > > > > instead of specifying "statsPublisher instanceof CounterStatsPublisher", how about to introduce new marker interface for publisher/aggregator something like AccumulatedStatProvider or something? Just a suggestion. I think that will be overkill. We already have 4 different ways of collecting stats, adding more interfaces will make it even more confusing. > On Dec. 5, 2013, 3:59 a.m., Navis Ryu wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java, line 980 > > > > > > can have a length issue but will be fixed by HIVE-5936. Yeah, could run into length issues though less likely since we now have shorter aggKey. Anyway, HIVE-5936 will take care of it. > On Dec. 5, 2013, 3:59 a.m., Navis Ryu wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 8515 > > > > > > comments might be fixed accordantly will, update the comment. > On Dec. 5, 2013, 3:59 a.m., Navis Ryu wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java, line 52 > > > > > > would it better to just adding ", e)" in the end? will do. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16026/#review29794 ----------------------------------------------------------- On Dec. 5, 2013, 1:01 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16026/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 1:01 a.m.) > > > Review request for hive and Navis Ryu. > > > Bugs: HIVE-5916 > https://issues.apache.org/jira/browse/HIVE-5916 > > > Repository: hive > > > Description > ------- > > No need to aggregate statistics collected via counter mechanism > > > Diffs > ----- > > trunk/itests/qtest/pom.xml 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java 1547966 > trunk/ql/src/test/queries/clientpositive/stats_counter_partitioned.q PRE-CREATION > trunk/ql/src/test/results/clientpositive/stats12.q.out 1547966 > trunk/ql/src/test/results/clientpositive/stats13.q.out 1547966 > trunk/ql/src/test/results/clientpositive/stats_counter_partitioned.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/16026/diff/ > > > Testing > ------- > > Added a new test case. Ran all other stats test. > > > Thanks, > > Ashutosh Chauhan > > --===============4480865150049906451==--