Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 179A2109C7 for ; Wed, 4 Dec 2013 17:41:57 +0000 (UTC) Received: (qmail 9958 invoked by uid 500); 4 Dec 2013 17:41:54 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 9922 invoked by uid 500); 4 Dec 2013 17:41:53 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 9902 invoked by uid 99); 4 Dec 2013 17:41:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Dec 2013 17:41:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 530921D3C80; Wed, 4 Dec 2013 17:41:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7090570690119561924==" MIME-Version: 1.0 Subject: Re: Review Request 15495: Implement vectorization support for IF conditional expression for long and double inputs From: "Eric Hanson" To: "Ashutosh Chauhan" , "Teddy Choi" Cc: "Eric Hanson" , "hive" Date: Wed, 04 Dec 2013 17:41:47 -0000 Message-ID: <20131204174147.12251.62793@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Eric Hanson" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/15495/ X-Sender: "Eric Hanson" References: <20131114190058.22290.75682@reviews.apache.org> In-Reply-To: <20131114190058.22290.75682@reviews.apache.org> Reply-To: "Eric Hanson" X-ReviewRequest-Repository: hive-git --===============7090570690119561924== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15495/ ----------------------------------------------------------- (Updated Dec. 4, 2013, 5:41 p.m.) Review request for hive, Ashutosh Chauhan and Teddy Choi. Bugs: HIVE-5756 https://issues.apache.org/jira/browse/HIVE-5756 Repository: hive-git Description ------- Implement vectorization support for IF conditional expression for long and double inputs Diffs (updated) ----- ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6 ql/src/gen/vectorization/ExpressionTemplates/IfExprColumnColumn.txt PRE-CREATION ql/src/gen/vectorization/ExpressionTemplates/IfExprColumnScalar.txt PRE-CREATION ql/src/gen/vectorization/ExpressionTemplates/IfExprScalarColumn.txt PRE-CREATION ql/src/gen/vectorization/ExpressionTemplates/IfExprScalarScalar.txt PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/DoubleColumnVector.java d3bb28e ql/src/java/org/apache/hadoop/hive/ql/exec/vector/LongColumnVector.java f65e8fa ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 29f3ae3 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIf.java 0c7e61c ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java ed5d195 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorConditionalExpressions.java PRE-CREATION Diff: https://reviews.apache.org/r/15495/diff/ Testing ------- Thanks, Eric Hanson --===============7090570690119561924==--