hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-5843) Transaction manager for Hive
Date Sat, 21 Dec 2013 21:22:09 GMT

    [ https://issues.apache.org/jira/browse/HIVE-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854941#comment-13854941
] 

Brock Noland commented on HIVE-5843:
------------------------------------

Alan,

Can you generate a patch which does not contain the generated code for reviewing purposes?

Also, you thrift methods should take a single request object and return a single response
object so the methods can be versioned. HS2 does a good job of this:

https://github.com/apache/hive/blob/trunk/service/if/TCLIService.thrift#L1020

> Transaction manager for Hive
> ----------------------------
>
>                 Key: HIVE-5843
>                 URL: https://issues.apache.org/jira/browse/HIVE-5843
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 0.12.0
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>             Fix For: 0.13.0
>
>         Attachments: HIVE-5843.2.patch, HIVE-5843.patch, HiveTransactionManagerDetailedDesign
(1).pdf
>
>
> As part of the ACID work proposed in HIVE-5317 a transaction manager is required.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message