hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Hanson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-5756) Implement vectorization support for IF conditional expression for long, double, timestamp and boolean inputs
Date Fri, 06 Dec 2013 00:08:35 GMT

    [ https://issues.apache.org/jira/browse/HIVE-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840719#comment-13840719
] 

Eric Hanson commented on HIVE-5756:
-----------------------------------

Item 2 (re: copySelected isRepeating handling) is fixed in combined patch.

Item 3: yes, we can fill a vector with the same value by using isRepeating=true, and filling
the vector entry 0. This is independent of whether selectedInUse is true. If selectedInUse
is true, only the selected row numbers will matter, but the value for all of them must come
from the repeating value for this column.

Item 4: I added this to Vectorizer.java:

    // For conditional expressions

    supportedGenericUDFs.add(GenericUDFIf.class);


> Implement vectorization support for IF conditional expression for long, double, timestamp
and boolean inputs
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-5756
>                 URL: https://issues.apache.org/jira/browse/HIVE-5756
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Eric Hanson
>            Assignee: Eric Hanson
>         Attachments: HIVE-5756.1.patch, HIVE-5756.2.patch, HIVE-5756.3.patch, HIVE-5756.4.patch,
HIVE-5756.5.patch, HIVE-5756.6.patch.txt
>
>
> Implement full, end-to-end support for IF in vectorized mode, including new VectorExpression
class(es), VectorizationContext translation to a VectorExpression, and unit tests for these,
as well as end-to-end ad hoc testing. An end-to-end .q test is recommended but optional.
> This is high priority because IF is the most popular conditional expression.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message