hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-3746) Fix HS2 ResultSet Serialization Performance Regression
Date Tue, 31 Dec 2013 22:42:52 GMT

    [ https://issues.apache.org/jira/browse/HIVE-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859755#comment-13859755
] 

Carl Steinbach commented on HIVE-3746:
--------------------------------------

+1

I'm fine with committing the patch in its current state, but there's one thing I think we
definitely need to fix ASAP in a followup patch. Up to this point we have managed to avoid
polluting the client and service class interfaces ( i.e. CLIService and CLIServiceClient)
with direct references to the Thrift serialization layer. This patch breaks that rule by exposing
TProtocolVersion in the public methods of CliService. Only ThriftCLIService should need to
know that the client is using a specific version of the Thrift serialization layer.

> Fix HS2 ResultSet Serialization Performance Regression
> ------------------------------------------------------
>
>                 Key: HIVE-3746
>                 URL: https://issues.apache.org/jira/browse/HIVE-3746
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HiveServer2, Server Infrastructure
>            Reporter: Carl Steinbach
>            Assignee: Navis
>              Labels: HiveServer2, jdbc, thrift
>         Attachments: HIVE-3746.1.patch.txt, HIVE-3746.2.patch.txt, HIVE-3746.3.patch.txt,
HIVE-3746.4.patch.txt, HIVE-3746.5.patch.txt, HIVE-3746.6.patch.txt, HIVE-3746.7.patch.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message