hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
Date Fri, 06 Dec 2013 22:57:35 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841839#comment-13841839
] 

Phabricator commented on HIVE-2093:
-----------------------------------

thejas has commented on the revision "HIVE-2093 [jira] create/drop database should populate
inputs/outputs and check concurrency and user permission".

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:257 why not return the location
uri here ?
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:1233 what qnName means
becomes clear only after reading the code, can you expand the variable name or add a javadoc
comment ?
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:2290 can you update
comment to say "SHOW LOCKS DATABASE [database] [extended]"
  ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java:104 you can use
- new Path(toURI)
  Its there since hadoop 0.20.2
  ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:83 why is this block of changes
needed ?
  It does not seem to be used anyway. I think the separation between entity and privileges
is a good thing.

REVISION DETAIL
  https://reviews.facebook.net/D12807

To: JIRA, navis
Cc: thejas


> create/drop database should populate inputs/outputs and check concurrency and user permission
> ---------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2093
>                 URL: https://issues.apache.org/jira/browse/HIVE-2093
>             Project: Hive
>          Issue Type: Bug
>          Components: Authorization, Locking, Metastore, Security
>            Reporter: Namit Jain
>            Assignee: Navis
>         Attachments: D12807.3.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt,
HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch,
HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch
>
>
> concurrency and authorization are needed for create/drop table. Also to make concurrency
work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message