hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request 16184: Hive should be able to skip header and footer rows when reading data file for a table (HIVE-5795)
Date Thu, 26 Dec 2013 18:31:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16184/#review30872
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/16184/#comment59093>

    It would be better to have FooterBuffer as a top level class in this package (...ql.exec)



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/16184/#comment59099>

    indentation needs fixing here



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/16184/#comment59103>

    can you please change the variable name from "ret" to something more descriptive like
"notEOF"



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/16184/#comment59104>

    return false, is little more easy to read



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/16184/#comment59100>

    indentation needs fixing here



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/16184/#comment59106>

    can you please change the variable name from "ret" to something more descriptive like
"notEOF"



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/16184/#comment59107>

    this else block looks unnecessary (as mentioned in my previous review)



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/16184/#comment59105>

    indentation needs fixing here


- Thejas Nair


On Dec. 19, 2013, 12:40 a.m., Shuaishuai Nie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16184/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 12:40 a.m.)
> 
> 
> Review request for hive, Eric Hanson and Thejas Nair.
> 
> 
> Bugs: hive-5795
>     https://issues.apache.org/jira/browse/hive-5795
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Hive should be able to skip header and footer rows when reading data file for a table
> (follow up with review https://reviews.apache.org/r/15663/diff/#index_header)
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fa3e048 
>   conf/hive-default.xml.template 1b30d19 
>   data/files/header_footer_table_1/0001.txt PRE-CREATION 
>   data/files/header_footer_table_1/0002.txt PRE-CREATION 
>   data/files/header_footer_table_1/0003.txt PRE-CREATION 
>   data/files/header_footer_table_2/2012/01/01/0001.txt PRE-CREATION 
>   data/files/header_footer_table_2/2012/01/02/0002.txt PRE-CREATION 
>   data/files/header_footer_table_2/2012/01/03/0003.txt PRE-CREATION 
>   itests/qtest/pom.xml 971c5d3 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java fc9b7e4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 9afc80b 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java dd5cb6b

>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 974a5d6 
>   ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java 85dd975

>   ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java 0686d9b 
>   ql/src/test/queries/clientnegative/file_with_header_footer_negative.q PRE-CREATION

>   ql/src/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION 
>   ql/src/test/results/clientnegative/file_with_header_footer_negative.q.out PRE-CREATION

>   ql/src/test/results/clientpositive/file_with_header_footer.q.out PRE-CREATION 
>   serde/if/serde.thrift 2ceb572 
>   serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
22a6168 
> 
> Diff: https://reviews.apache.org/r/16184/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shuaishuai Nie
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message