hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jitendra Pandey" <jiten...@hortonworks.com>
Subject Re: Review Request 16229: HIVE-6010 create a test that would ensure vectorization produces same results as non-vectorized execution
Date Mon, 16 Dec 2013 21:19:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16229/#review30464
-----------------------------------------------------------



ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java
<https://reviews.apache.org/r/16229/#comment58282>

    We should throw an exception if it is null. What is the reason for the change in behavior?



ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java
<https://reviews.apache.org/r/16229/#comment58283>

    Is it ok to write to stdout?



ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv
<https://reviews.apache.org/r/16229/#comment58288>

    The name of the file could be suffixed to indicate vectorization disabled or enabled.


- Jitendra Pandey


On Dec. 13, 2013, 7:15 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16229/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 7:15 p.m.)
> 
> 
> Review request for hive and Jitendra Pandey.
> 
> 
> Bugs: HIVE-6010
>     https://issues.apache.org/jira/browse/HIVE-6010
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See jira.
> 
> 
> Diffs
> -----
> 
>   ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java 85351aa 
>   itests/qtest/pom.xml 8c249a0 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java c16e82d 
>   ql/src/test/queries/clientcompare/vectorized_math_funcs.q PRE-CREATION 
>   ql/src/test/queries/clientcompare/vectorized_math_funcs_00.qv PRE-CREATION 
>   ql/src/test/queries/clientcompare/vectorized_math_funcs_01.qv PRE-CREATION 
>   ql/src/test/templates/TestCompareCliDriver.vm PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16229/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message