hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar" <pras...@cloudera.com>
Subject Re: Review Request 16207: HIVE-1466: Add NULL DEFINED AS to ROW FORMAT specification
Date Fri, 13 Dec 2013 03:35:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16207/
-----------------------------------------------------------

(Updated Dec. 13, 2013, 3:35 a.m.)


Review request for hive and Xuefu Zhang.


Changes
-------

Fixed formatting (tabs)
Fixed 'show create table' to support null format
Added testcase for CTAS


Bugs: HIVE-1466
    https://issues.apache.org/jira/browse/HIVE-1466


Repository: hive-git


Description
-------

Support configurable null format for tables and writing out to directory.
Using a non-default null format is a bit while creating a table, and pretty much impossible
to export the data to local filesystem using insert overwrite directory.
The patch enhances the SQL syntax to support 'NULL DEFINED AS' construct for create table
as well as insert overwrite directory.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 41df473 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java fdc0d1a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 366b714 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g b146df6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 8cf5ad6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ace1df9 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 93b4181 
  ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java b6097b1 
  ql/src/test/queries/clientpositive/nullformat.q PRE-CREATION 
  ql/src/test/queries/clientpositive/nullformatCTAS.q PRE-CREATION 
  ql/src/test/queries/clientpositive/nullformatdir.q PRE-CREATION 
  ql/src/test/results/clientpositive/nullformat.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/nullformatCTAS.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/nullformatdir.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/16207/diff/


Testing
-------

Added new tests.


Thanks,

Prasad Mujumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message